Remove workaround for modal closing in Firefox#333
Conversation
Removed temporary workaround for modal closing behavior in Firefox, added in #185
There was a problem hiding this comment.
Pull request overview
This pull request removes a temporary workaround that was added to fix a Firefox-specific bug where the revalidation modal would immediately close when users clicked inside the iframe. The workaround disabled the ability to close the modal by clicking outside of it (shouldCloseOnClickOutside={ false }). With the upstream Gutenberg fix (PR #51602) now resolved, this workaround is no longer needed and can be safely removed.
Changes:
- Removed the
shouldCloseOnClickOutside={ false }prop from the RevalidateModal component - Removed associated comments explaining the temporary workaround
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dd32
left a comment
dd32
left a comment
There was a problem hiding this comment.
This should be safe to merge based on my understanding. We def run a newer Gutenberg version too :)
|
@adamwoodnz Please note: If you want to deploy this to w.org you'll need to test everything, as the upstream two-factor has changed a bunch of stuff that might cause 2fa to break on w.org.. I'm not actually sure.. |
See #180
Removed temporary workaround for modal closing behavior in Firefox, now that WordPress/gutenberg#51602 is fixed.
Workaround was added in #185